Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask]: Remove IcebergContentFile and related codes #1839

Closed
2 of 3 tasks
Tracked by #1837
, #1930
...
zhoujinsong opened this issue Aug 14, 2023 · 0 comments
Closed
2 of 3 tasks
Tracked by #1837
, #1930
...

[Subtask]: Remove IcebergContentFile and related codes #1839

zhoujinsong opened this issue Aug 14, 2023 · 0 comments
Assignees
@huyuanfeng2018
Labels
type:subtask Subtask of another issue

Comments

@zhoujinsong
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

Description

Before Iceberg version 1.3, you can not get the file sequence number and data sequence number of files.
Amoro implements IcebergContentFile to expose the sequence number and SequenceNumberFetcher to fetch the sequence number.

But As we have upgraded Iceberg to version 1.3, we can get the sequence numbers from org.apache.iceberg.ContentFile directly. And this will reduce code complexity and improve performance.

Parent issue

#1837

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huyuanfeng2018 huyuanfeng2018

Labels
type:subtask Subtask of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhoujinsong @huyuanfeng2018 @wangtaohz