Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support killing the running optimizing process #1862

Closed
3 of 4 tasks
Tracked by #2176
archer2012 opened this issue Aug 21, 2023 · 6 comments
Closed
3 of 4 tasks
Tracked by #2176

[Feature]: Support killing the running optimizing process #1862

archer2012 opened this issue Aug 21, 2023 · 6 comments
Labels
type:feature Feature Requests

Comments

@archer2012
Copy link
Contributor

archer2012 commented Aug 21, 2023

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Due to some historical reasons, for some tables with serious fragmentation, it may require a lot of resources to enable self-o
ptimize for the first time, and even cannot be merged or take a long time. We hope to kill or skip this optimize process

74978f2911a1e26c698fb1cfc419c18

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

Code of Conduct

@baiyangtx
Copy link
Contributor

baiyangtx commented Aug 22, 2023

Thank you for suggesting this improvement. 'kill optimizing' is a relatively important operations and maintenance requirement. Currently, the preliminary plan is to implement this function in the standard operations and maintenance instructions. You can follow it in this issue

However, before that, should we provide other ways to solve such operations and maintenance problems? For example, providing a script to clean up optimizing processes and so on. @zhoujinsong

@zhoujinsong zhoujinsong changed the title [Improvement]: How to kill the running optimize process [Feature]: Support killing the running optimizing process Oct 24, 2023
@zhoujinsong zhoujinsong added type:feature Feature Requests and removed type:improvement labels Oct 24, 2023
@zhoujinsong zhoujinsong mentioned this issue Oct 24, 2023
66 tasks
@wangtaohz
Copy link
Contributor

However, before that, should we provide other ways to solve such operations and maintenance problems? For example, providing a script to clean up optimizing processes and so on. @zhoujinsong

From a product design perspective, I think providing a Cancel operation (maybe a button) for each optimizing process in Web UI is a practical way, that will provide convenience for optimizing recovery and retry.

@zhongqishang
Copy link
Contributor

That's cool.

But I prefer the Cancel button as @wangtaohz said, If just cancel the task, I believe it will be scheduled again to generate a new optimize task.
Maybe we can provided a button to enable/disable self-optimizing?
After disable self-optimizing, cancel the currently executing optimizing task.

@tcodehuber
Copy link
Contributor

This feature is valuable for external optimizers. I have implemented this part of the code logic as @wangtaohz mentioned, can you assign a subtask to me for contribution.

1 similar comment
@tcodehuber
Copy link
Contributor

This feature is valuable for external optimizers. I have implemented this part of the code logic as @wangtaohz mentioned, can you assign a subtask to me for contribution.

@wangtaohz
Copy link
Contributor

This feature is valuable for external optimizers. I have implemented this part of the code logic as @wangtaohz mentioned, can you assign a subtask to me for contribution.

👍 @tcodehuber You can create your own subtask and describe your approach, and I can assist in assigning the subtask to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

7 participants