Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Extract the deleting dangling files from the cleaning orphan files #2261

Closed
2 of 3 tasks
wangtaohz opened this issue Nov 7, 2023 · 1 comment · Fixed by #2403
Closed
2 of 3 tasks

[Improvement]: Extract the deleting dangling files from the cleaning orphan files #2261

wangtaohz opened this issue Nov 7, 2023 · 1 comment · Fixed by #2403
Assignees
@xujiangfeng001
Labels
good first issue Good for newcomers type:improvement

Comments

@wangtaohz
Copy link
Contributor

wangtaohz commented Nov 7, 2023 •
edited
Loading

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, the deletion of dangling files is performed during the process of cleaning orphan files where com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer#cleanDanglingDeleteFiles.

We should separate these two functions so that they can be executed independently.

How should we improve?

Deleting dangling files should be a specialized funtion of com.netease.arctic.server.optimizing.maintainer.TableMaintainer.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@xujiangfeng001
Copy link
Contributor

Please assign it to me so that I can complete it. @wangtaohz

@xujiangfeng001 xujiangfeng001 mentioned this issue Dec 4, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xujiangfeng001 xujiangfeng001

Labels
good first issue Good for newcomers type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-2261] Extract the deleting dangling files from the cleaning orphan files xujiangfeng001/amoro
2 participants
@wangtaohz @xujiangfeng001