Store the script.ID in the router entity?

[spacewander]

It seems currently there is not reference between /apisix/route and the /apisix/script?

[tokers]

That's really, we may add the reference relations just like route and upstream.

[nic-chen]

sure, we should store it.

[membphis]

yes, we need this feature ^_^

APISIX needs to be updated for this feature, all right? @spacewander

[spacewander]

Yes.

[juzhiyuan]

any update?

[spacewander]

APISIX already updated for this feature

[juzhiyuan]

ok, waiting manager-api's update.

[membphis]

ping @nic-chen

[juzhiyuan]

done??

[imjoey]

done??

@juzhiyuan I will work on this if no one has taken.

[juzhiyuan]

All right, thanks!

[imjoey]

APISIX already updated for this feature

@spacewander AFAIK, APISIX seems not going to deal with loading script by script_id from etcd, which acts not the same as upstream_id. So just to confirm with you that in manager-api, we must fulfill the script property if the input only contains the script_id. Please let me know if I'm wrong. Thanks.

[spacewander]

The script_id is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id.

[imjoey]

The script_id is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id.

@spacewander thanks for getting back. So could we have the following assumptions for now:

• Currently users could not manipulate the script via manager-api, which means there are no explicite CURDL APIs for script object.
• If the script_id in request does not equal to the id of the affiliated route, we can directly send back the Bad Request response.

Thanks.

[spacewander]

I think just filling the script_id field with the route id when the script is saved is enough.

[imjoey]

I think just filling the script_id field with the route id when the script is saved is enough.

@spacewander Wow, that's great. Many thanks for clear directions.

[imjoey]

@spacewander @tokers @juzhiyuan

For now, APISIX and manager-api have both supported script_id in Route entity. Cause The script_id is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id., IMHO there is no need to do anything else in manager FE, so could we close this issue?

[juzhiyuan]

agree with u.