Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify the usage of upstream and service go-jsonpatch to json-patch/v5 #1392

Closed
Jaycean opened this issue Jan 29, 2021 · 3 comments
Closed
Assignees
Labels

Comments

@Jaycean
Copy link
Member

Jaycean commented Jan 29, 2021

Feature request

Please describe your feature

When I look at the test cases, I find that the jsonpatch(github.com/api7/go-jsonpatch) used by upstream and service when calling the patch method is still the old package, but I see that PR:#1005 has been updated to github.com/evanphx/json-patch/v5,The current use of old packages will also result in interface errors, so I'm going to fix them.

Describe the solution you'd like

I will submit PR to make upstream and service use the new package.

Ping @starsz @nic-chen @imjoey .
Pls assign to me. Thks

@Jaycean Jaycean changed the title feat: Modify the usage of upstream and service github.com/evanphx/json-patch/v5 feat: Modify the usage of upstream and service go-jsonpatch to json-patch/v5 Jan 29, 2021
@imjoey
Copy link
Member

imjoey commented Jan 29, 2021

@Jaycean thanks for reporting. IMHO, this is indeed a bug and we should omit the dependency of github.com/api7/go-jsonpatch and use github.com/evanphx/json-patch/v5 for all cases.

Ping @nic-chen for comfirmation. Thanks.

@nic-chen
Copy link
Member

@imjoey @Jaycean that's great, thanks!

@Jaycean
Copy link
Member Author

Jaycean commented Feb 1, 2021

PR merged. Now close the issue and open it again if there is any problem

@Jaycean Jaycean closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants