Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBalancer_roundrobin_with_weight failed #1401

Closed
juzhiyuan opened this issue Jan 30, 2021 · 9 comments
Closed

TestBalancer_roundrobin_with_weight failed #1401

juzhiyuan opened this issue Jan 30, 2021 · 9 comments
Assignees
Labels
backend bug Something isn't working testcase

Comments

@juzhiyuan
Copy link
Member

fine, I don't mean CI failed due to this PR 😂 just saw after PR merged, CI down.

image

Originally posted by @juzhiyuan in #1396 (comment)

@imjoey
Copy link
Member

imjoey commented Jan 30, 2021

FYI, this failure began since this morning, and 100% reproducible.

@juzhiyuan juzhiyuan added the bug Something isn't working label Jan 30, 2021
@Jaycean
Copy link
Member

Jaycean commented Jan 30, 2021

I just ran the local test file balancer_ test.go There is no problem with it. This problem occurred this morning, making PR CI unable to pass. I also implemented 'go test -v', and there is no problem.

@Jaycean
Copy link
Member

Jaycean commented Jan 30, 2021

In addition, in the development process, I also feel that there are many CI test cases, and the error information is very vague. When there are errors in the test cases, it also makes it more difficult for us to locate the problem. Of course, it takes a lot of time to improve this thing.

@Jaycean
Copy link
Member

Jaycean commented Feb 1, 2021

@juzhiyuan Hi,PR #1395 has fixed the problem. The reason for the problem is apisix has modified luajit. @nic-chen has fixed the problem.

@imjoey
Copy link
Member

imjoey commented Feb 1, 2021

@juzhiyuan Hi,PR #1395 has fixed the problem. The reason for the problem is apisix has modified luajit. @nic-chen has fixed the problem.

@Jaycean yep, while we would better see the CI result triggered by 94d952f push event before close this issue.

@juzhiyuan
Copy link
Member Author

@imjoey
Copy link
Member

imjoey commented Feb 1, 2021

https://github.com/apache/apisix-dashboard/runs/1804604649#step:4:703

failed due to luasec.

@juzhiyuan yep, this may be caused by the lua path, related to apache/apisix#3335 authored by @fukiki . We are trying to fix this. 😄

@Jaycean Jaycean mentioned this issue Feb 1, 2021
4 tasks
@Jaycean
Copy link
Member

Jaycean commented Feb 1, 2021

@juzhiyuan Hi,The problem has been solved. Since APISIX has modified Luajit to cause dependency environment problems, the dockfile has been modified to fix it. As mentioned in PR, pulling the dockerfile file of remote apifix should open a new issue discussion.This issue can be closed.

@nic-chen
Copy link
Member

nic-chen commented Feb 1, 2021

thanks @Jaycean

@nic-chen nic-chen closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working testcase
Projects
None yet
Development

No branches or pull requests

5 participants