Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Lua's __index to mock all of the share dict #671

Closed
1 task done
membphis opened this issue Nov 2, 2020 · 7 comments
Closed
1 task done

feat: use Lua's __index to mock all of the share dict #671

membphis opened this issue Nov 2, 2020 · 7 comments
Assignees
Labels
Milestone

Comments

@membphis
Copy link
Member

membphis commented Nov 2, 2020

  • Why do you submit this issue?
  • Feature or performance improvement

Question

  • What do you want to know?

original comment: https://github.com/apache/apisix-dashboard/pull/651/files#r516339002


Requirements or improvement

  • Please describe your requirements or improvement suggestions.

__index can mock all of the share dicts, even we can use it to mock all of the API in ngx.

@juzhiyuan juzhiyuan added the wait for update 1. Solution 2. Due date 3. Assignees if needed label Nov 24, 2020
@juzhiyuan
Copy link
Member

done?

@juzhiyuan juzhiyuan added this to the 2.4 milestone Jan 8, 2021
@juzhiyuan
Copy link
Member

cc @starsz

@starsz
Copy link
Contributor

starsz commented Jan 8, 2021

Please assign it to me. I will improve the schema-sync.lua.

Releated: #1237.

@juzhiyuan juzhiyuan removed the wait for update 1. Solution 2. Due date 3. Assignees if needed label Jan 8, 2021
@nic-chen
Copy link
Member

we don't need the tool schema-sync now, we could use APISIX controlAPI to export schema.
we only need to update doc about sync schema here.

@nic-chen
Copy link
Member

it's same with #1237 , we could close this now.

@juzhiyuan
Copy link
Member

@nic-chen Please remove any related text from this repo if needed

@nic-chen
Copy link
Member

@nic-chen Please remove any related text from this repo if needed

sure, we will update the doc, and track it in #1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants