-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor error log for manager api
#678
Comments
https://github.com/cilium/cilium/blob/master/pkg/logging/logging.go it seems a good choice. |
manager api
manager api
manager api
manager api
@membphis zap is better than logrus for us, I'm sure about that. |
nice @nic-chen ^_^ can you list some reason? We need to why. |
it has almost the same feature and much faster. and it support atomic level, sampling .. etc advanced features |
Nice got it. And I check the license, it is MIT, good for us too. Please confirm whether it will introduce new dependent libraries and their licenses are acceptable. |
done. rotate should be done with |
relate to #620
we could use zap that most gophers recommend.
The text was updated successfully, but these errors were encountered: