Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: improve docker test #703

Closed
nic-chen opened this issue Nov 5, 2020 · 4 comments
Closed

CI: improve docker test #703

nic-chen opened this issue Nov 5, 2020 · 4 comments
Labels
enhancement New feature or request testcase

Comments

@nic-chen
Copy link
Member

nic-chen commented Nov 5, 2020

currently CI for docker test is too simple, it just test docker build, can not catch docker run error :
https://github.com/apache/apisix-dashboard/blob/v2.0/.github/workflows/test-docker.yml

we need to check:

  1. docker run OK
  2. access to web(page) successful, not 404
  3. api for plugin orchestration works fine.
@nic-chen nic-chen added enhancement New feature or request testcase labels Nov 5, 2020
@membphis
Copy link
Member

membphis commented Nov 5, 2020

yes, we need this. nice

@juzhiyuan
Copy link
Member

juzhiyuan commented Nov 5, 2020 •
edited
Loading

How about adding those tests in this PR? #701

This action is used to Test then Deploy with Docker, if it's failed in test, then the deploy would be terminated, too.

@nic-chen
Copy link
Member Author

nic-chen commented Nov 6, 2020

LGTM

@nic-chen
Copy link
Member Author

close since #701 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testcase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juzhiyuan @membphis @nic-chen