Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ssl synchronization is pathlogical #179

Closed
tokers opened this issue Jan 19, 2021 · 1 comment · Fixed by #203
Closed

bug: ssl synchronization is pathlogical #179

tokers opened this issue Jan 19, 2021 · 1 comment · Fixed by #203
Assignees
Milestone

Comments

@tokers
Copy link
Contributor

tokers commented Jan 19, 2021

Issue description

The logic for synchronizing ApisixSSL is pathlogical, we don't have a name/fullname field to index the SSL object in cache, so as to we cannot get its id in APISIX, the Update/Delete will failure.

Environment

  • your apisix-ingress-controller version: master branch
  • your Kubernetes cluster version: have nothing to do with the Kubernetes cluster version
  • if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a).

What's the actual result? (including assertion message & call stack if applicable)

The Update/Delete of SSL should be successful.

What's the expected result?

The apisix-ingress-controller crashes since the ssl.ID is nil.

@gxthrj
Copy link
Contributor

gxthrj commented Jan 19, 2021

Thanks, It is a bug, I will fix it.

@gxthrj gxthrj self-assigned this Jan 19, 2021
@gxthrj gxthrj mentioned this issue Jan 25, 2021
4 tasks
@gxthrj gxthrj added this to the 0.3.0 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants