Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a "namespace" parameter to the "plugin_config" of apisixRoute, to share the same apisixPluginConfig between all namespaces of apisixRoutes #2132

Closed
seethedoor opened this issue Jan 11, 2024 · 2 comments · Fixed by #2137

Comments

@seethedoor
Copy link

seethedoor commented Jan 11, 2024

Description

We are using apisixRoutes, and now we need to add a common plugin_config to all of the routes. But I found that apisixRoute spec params only support plugin_config_name, and it will only search apisixPluginConfig in the same namespace of the apisixRoute.
This will require to create the same apisixPluginConfigs for all namespaces and maintain these apisixPluginConfigs as namespaces change. If we can add a plugin_config_namespace parameter under the apisixRoute spec, combined with the plugin_config_name, we can solve the above problem with just one apisixPluginConfig.

@seethedoor seethedoor changed the title feat: It is necessary to add a "namespace" parameter to the "plugin_config" of apisixRoute, so that apisixRoutes under multiple namespaces can share the same apisixPluginConfig. feat: Add a "namespace" parameter to the "plugin_config" of apisixRoute, to share the same apisixPluginConfig between all namespaces. Jan 11, 2024
@seethedoor seethedoor changed the title feat: Add a "namespace" parameter to the "plugin_config" of apisixRoute, to share the same apisixPluginConfig between all namespaces. feat: Add a "namespace" parameter to the "plugin_config" of apisixRoute, to share the same apisixPluginConfig between all namespaces of apisixRoutes Jan 11, 2024
@Gallardot
Copy link
Member

Good idea. I believe this will help to reduce maintenance costs.

@Revolyssup Revolyssup self-assigned this Jan 16, 2024
@Revolyssup Revolyssup moved this from 📋 Backlog to 🏗 In progress in Apache APISIX backlog Jan 16, 2024
@Revolyssup
Copy link
Contributor

@seethedoor Thanks for reporting. I'll take this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants