Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo or invalid mark for Docusaurus #686

Closed
4 tasks
juzhiyuan opened this issue Oct 28, 2021 · 9 comments
Closed
4 tasks

docs: typo or invalid mark for Docusaurus #686

juzhiyuan opened this issue Oct 28, 2021 · 9 comments
Labels
Docs good first issue Good for newcomers
Milestone

Comments

@juzhiyuan
Copy link
Member

juzhiyuan commented Oct 28, 2021

URL: https://apisix.apache.org/blog/2021/07/25/apachecon-asia

  • We should load images from CDN
  • Markdown invalid

image
image

URL: https://apisix.apache.org/blog/2021/06/17/Apache-APISIX-Dashboard-Access-Control-Bypass-Vulnerability-Announcement/

  • <! --truncate --> invalid

URL: https://apisix.apache.org/blog/2021/10/27/APISIX%20Ingress

  • Link invalid
    image

cc @yzeng25

@juzhiyuan juzhiyuan added good first issue Good for newcomers Docs labels Oct 28, 2021
@juzhiyuan juzhiyuan added this to the V2.1 milestone Oct 28, 2021
@yzeng25
Copy link
Contributor

yzeng25 commented Oct 29, 2021

Hi,
the issues listed above are:

  1. Missing Shuyang's profile picture
  2. <! --truncate --> invalid
  3. Invalid link in markdown file
  4. Store pictures/images in CDN.

I solved 123 in #689, while problem 4 "Store pictures/images in CDN" would be a good first issue.

For clarification, is it expected to migrate all pictures/images to CDN, or just for pictures/images that would be added in the future, and we can leave previous pictures/images alone?

I can provide step-by-step instructions on the part, but migrating all pictures/images would be too much to handle for me. Thus, help from community is needed.

@yzeng25
Copy link
Contributor

yzeng25 commented Oct 29, 2021

The steps of importing images to CDN is listed below:

  1. Locate the images that need to be migrate to CDN

  2. Download the images to your machine

  3. Visit the CDN migration page https://markdown.apiseven.com/#/

  4. Click either one of the following buttons to start uploading(single and multiple are both supported).
    image

  5. Click this button to continue uploading images, select images you need to upload,
    image

  6. After successfully uploaded, a link is generated for each image.
    image

  7. Copy the links and replace the origin links with these link.

@Ylikj
Copy link
Contributor

Ylikj commented Oct 30, 2021

@yzeng25 hi ,let me have a try, and I want to make sure that I need to replace all the pictures?

@juzhiyuan
Copy link
Member Author

Yes

@yzeng25
Copy link
Contributor

yzeng25 commented Nov 1, 2021

@yzeng25 hi ,let me have a try, and I want to make sure that I need to replace all the pictures?

Yes, thanks!

@juzhiyuan
Copy link
Member Author

@Ylikj Any update here?

@Ylikj
Copy link
Contributor

Ylikj commented Nov 4, 2021

@juzhiyuan at pr#694,but there is something wrong, I will revise it tonight

@SkyeYoung
Copy link
Member

Any update here?

@yzeng25
Copy link
Contributor

yzeng25 commented Mar 23, 2022

I think this issue is solved long ago by #810. We should close it.
cc @juzhiyuan @bzp2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants