New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: throw an error message if there was no valid upstream node in balance phase #1291

Closed

membphis opened this issue Mar 18, 2020 · 0 comments · Fixed by #1292

Labels

bug

Member

membphis commented Mar 18, 2020

If the user uses the domain as an upstream node host.
We need to parse the domain by DNS first, and this step may fail.

Then the upstream node may be an empty table.

curl "http://127.0.0.1:9080/apisix/admin/upstreams/50" -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
    "type": "roundrobin",
    "nodes": {
        "httpbin.org:443": 1
    }
}'

membphis added the bug label

membphis mentioned this issue

bugfix: check the count of upstream valid node. #1292

Merged

membphis closed this as completed in #1292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment