Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: cors plugin can not work with auth plugins #1528

Closed
ShiningRush opened this issue Apr 29, 2020 · 1 comment
Closed

request help: cors plugin can not work with auth plugins #1528

ShiningRush opened this issue Apr 29, 2020 · 1 comment

Comments

@ShiningRush
Copy link
Contributor

ShiningRush commented Apr 29, 2020

Issue description

Now our cors plugin work in header_filter phase, so if someone enables both auth plugin(such as key-auth or jwt-auth) and core plugin, then authenticate failed, the cors header will not append to header, it will cause browser raising a cors error and drop the response.

I think we should:

  • Change the core plugin work in rewrite phase (I will do it today)
  • Change auth plugins work in access phase, I think the authentication would better be doing in access phase, it is design for it.

Welcome to discuss.

@membphis
Copy link
Member

fixed already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants