Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor SSL logic #1578

Closed
moonming opened this issue May 12, 2020 · 1 comment
Closed

refactor SSL logic #1578

moonming opened this issue May 12, 2020 · 1 comment
Assignees

Comments

@moonming
Copy link
Member

But this poses a risk that the SNI and expiration times are likely to be inconsistent with SSL certificates, and there is now no validation mechanism.
A better approach would be:

  1. add checks for public and private keys
  2. the sni and expiration time are automatically obtained from the certificate.

This PR can be a temporary implementation that will be refactored later. A new issue can be created.

Originally posted by @moonming in #1571 (comment)

@spacewander spacewander self-assigned this Dec 21, 2020
@spacewander
Copy link
Member

Solved by #3085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants