New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(prometheus): support to hot reload #1610

Closed

membphis opened this issue May 25, 2020 · 2 comments

Member

membphis commented May 25, 2020

This is the current todo comments:

https://github.com/apache/incubator-apisix/pull/1607/files#diff-dc8151ecf7fc460e27a70fb1e00e7f55R53

The metrics can only be initialized in the init and init worker phases, and we need to let it support other phases.

membphis mentioned this issue

change: updated prometheus to version 1.1 . #1607

Merged

Contributor

liuhengloveyou commented Sep 30, 2020

Does it need to close now?

Member Author

membphis commented Sep 30, 2020

yes

membphis closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment