Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Missing the CODE_STYLE.md file #1846

Closed
yongboy opened this issue Jul 15, 2020 · 3 comments · Fixed by #1874
Closed

bug: Missing the CODE_STYLE.md file #1846

yongboy opened this issue Jul 15, 2020 · 3 comments · Fixed by #1874

Comments

@yongboy
Copy link
Contributor

yongboy commented Jul 15, 2020

Summary

I can't find the CODE_STYLE.md file in the project path：

* [Code Style](../CODE_STYLE.md)

:((
@moonming
Copy link
Member

The original code style was OpenResty and did not meet the branding requirements of Apache APISIX.
Feel free to modify the original file and submit a PR

@Miss-you
Copy link
Member

Miss-you commented Jul 15, 2020 •
edited
Loading

I think it would be more appropriate to use this document as a code style guide.
https://github.com/luarocks/lua-style-guide

@Miss-you
Copy link
Member

#1848

@yongboy yongboy mentioned this issue Jul 20, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX
3 participants
@yongboy @Miss-you @moonming