-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSS] Should we add metric for log sender and zipkin ? #2693
Comments
I do it in my private repository should apisix need it? |
Could you provide a design about it? |
I think we need to allow plugin to register their metrics. Like a |
When prometheus exporter init , I add a gauge to metric with label : node,route_id, type。And I export two module function inc and set to change the gauge value. In "syslog-plugin" log method, I use this module method inc it value, and in batch process I reduce it value. And zipkin is also do that. |
We can add plugin init method to register their own metric,And provide api to change it value. |
@gy09535 |
haha, I wil do it. |
Please assign to me. |
Issue description
Now the log sender batch store the data in memory , we can not know how many logs or spans is send, so I think we can add some metric to monitor it.
Environment
apisix version
):The text was updated successfully, but these errors were encountered: