Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The consumer-restriction plugin using service_id type restriction does not take effect #3106

Closed
whioue opened this issue Dec 23, 2020 · 4 comments

Comments

@whioue
Copy link

whioue commented Dec 23, 2020

Issue description

想要consumer来绑定服务或路由,所以使用consumer-restriction插件来实现,使用这个插件有两种限制类型,一种是使用consumer_name这个没问题,另一种是service_id使用时,发现文档上实例是key-auth认证,这个没问题,但我使用此插件限制basic-auth时发现无法限制成功

Environment

  • apisix version (cmd: apisix version):
  • OS:

Minimal test code / Steps to reproduce the issue

What's the actual result? (including assertion message & call stack if applicable)

What's the expected result?

@spacewander
Copy link
Member

Is it solved by #2905? You can try it on the master branch.

@whioue
Copy link
Author

whioue commented Dec 23, 2020

Is it solved by #2905? You can try it on the master branch.
@spacewander
I tried it on version 2.0 and it seems that it has not been solved for the time being

@spacewander
Copy link
Member

I can reproduce with 2.0, but can't reproduce with master branch. The fix is only on the master branch. Can you try the master branch directly? Remember to stop and restart APISIX entirely.

@moonming moonming changed the title consumer-restriction插件使用service_id类型限制不生效 The consumer-restriction plugin using service_id type restriction does not take effect Dec 23, 2020
@whioue
Copy link
Author

whioue commented Dec 23, 2020

I can reproduce with 2.0, but can't reproduce with master branch. The fix is only on the master branch. Can you try the master branch directly? Remember to stop and restart APISIX entirely.
@spacewander it's solved thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants