-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discuss]: enable etcd health check #3692
Comments
Yes, it just uses the FQDN since the underlying cosocket suite supports to resolve it according to the We may, resolving the FQDN (and cache it) by ourselves in the level of lua-resty-etcd. |
I think we need to resolve it in the APISIX side as lua-resty-etcd knows nothing about the resolver. |
agree, etcd |
For this case maybe we can resolve the domain each time before retry? |
Maybe we can do it, but I think we can also do without. My point is: if you configure the I'm not sure if this is a correct point, just a perception. |
I doubt if it is a good idea to combine the health check with domain resolution, as the health check methods are various and can't detect the healthy one immediately. |
yes, you are right |
Hi @tzssangglass are you still working on this 😀 I could take care of it if you do not got enough time |
okay, I haven't had enough time lately, so leave it to you. |
Already done. |
Issue description
I saw this issue #3673 and this pr #3676.
I think it's time to enable the etcd health check feature.
by the way, etcd's
host
configuration, if it is in the form ofip:port
, the health check takes effect, if it is in the form of domain, the health check fails because etcd's node is hidden behind the domain and cannot be distinguished, so use the FQDN of etcd in k8s does not solve the issues #3673.The text was updated successfully, but these errors were encountered: