Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin server-info will write data to etcd #3775

Closed
juzhiyuan opened this issue Mar 7, 2021 · 8 comments
Closed

plugin server-info will write data to etcd #3775

juzhiyuan opened this issue Mar 7, 2021 · 8 comments
Assignees
Labels
question label for questions asked by users stale

Comments

@juzhiyuan
Copy link
Member

Question

Please describe which part of docs should be improved or typo fixed

Hi, the Apache APISIX implements the server-info plugin in #2926 #2821, and this plugin will set data to etcd here[1] 🤔 this will lead to conflicts with the original design: DP will only READ data from etcd.

I'm not sure if we need to have some changes to this plugin 🤔

[1] https://github.com/apache/apisix/pull/2926/files#diff-874bdf83da087cde5a431f91ce48ffc6bc042c5b3a64c6e21b1ca799b9261f66R137

@juzhiyuan juzhiyuan added the question label for questions asked by users label Mar 7, 2021
@membphis
Copy link
Member

membphis commented Mar 8, 2021

DP is read-only to etcd data, making it easier to control security.
I suggest keeping it read-only for DP.

@tokers
Copy link
Contributor

tokers commented Mar 8, 2021

It's difficult to do it without introducing any other components.

@membphis
Copy link
Member

membphis commented Mar 9, 2021

I think we should disable this feature by default, keep read-only for DP

@github-actions
Copy link

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 22, 2022
@membphis
Copy link
Member

@nic-chen Do you have any news about this issue?

@nic-chen
Copy link
Member

@nic-chen Do you have any news about this issue?

We're using keepalive instead of always updating, but it's still writing, not read-only: #6202

@github-actions github-actions bot removed the stale label Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 9, 2023
@github-actions
Copy link

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question label for questions asked by users stale
Projects
None yet
Development

No branches or pull requests

4 participants