Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Supplement the schema in deployment #8804

Closed
tao12345666333 opened this issue Feb 7, 2023 · 4 comments · Fixed by #8809
Closed

chore: Supplement the schema in deployment #8804

tao12345666333 opened this issue Feb 7, 2023 · 4 comments · Fixed by #8809
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tao12345666333
Copy link
Member

Description

Apache APISIX v3 adds a decoupled deployment mode. ref: https://apisix.apache.org/docs/apisix/deployment-modes/#decoupled

The current schema is not perfect.

When the role is control_plane, it should contain the configuration of the admin field, which is consistent with traditional.

control_plane = {
properties = {
etcd = etcd_schema,
role_control_plane = {
properties = {
config_provider = {
enum = {"etcd"}
},
conf_server = {
properties = {
listen = {
type = "string",
default = "0.0.0.0:9280",
},
cert = { type = "string" },
cert_key = { type = "string" },
client_ca_cert = { type = "string" },
},
required = {"cert", "cert_key"}
},
},
required = {"config_provider", "conf_server"}
},
certs = {
properties = {
cert = { type = "string" },
cert_key = { type = "string" },
trusted_ca_cert = { type = "string" },
},
dependencies = {
cert = {
required = {"cert_key"},
},
},
default = {},
},
},
required = {"etcd", "role_control_plane"}

xref: apache/apisix-helm-chart#459

@tao12345666333 tao12345666333 added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 7, 2023
@jiangfucheng
Copy link
Member

jiangfucheng commented Feb 7, 2023

Hi, could assign it to me, i want to try it.

@rukundob451
Copy link

@tao12345666333 was the issue worked on?

@tokers
Copy link
Contributor

tokers commented Feb 12, 2023

@jiangfucheng Did you start it? I can assign it to you.

@jiangfucheng
Copy link
Member

@jiangfucheng Did you start it? I can assign it to you.

I was submit a pr #8809, but still has some problem, could you guide me slove it? I can't reproduce it in my local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants