Skip to content

Commit fda797b

Browse files
committed
fix(r/adbcflightsql): fix warnings on R CMD check for Go-based drivers
1 parent 8da67a4 commit fda797b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/r-basic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@ jobs:
6161
pkg: ${{ matrix.pkg }}
6262
# For the r-basic check (that runs on many PRs), just check ERRORs
6363
# (e.g., build failure, test failure)
64-
error-on: error
64+
error-on: warning
6565
secrets:
6666
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}

r/adbcflightsql/src/Makevars.in

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,12 @@ CGO_CXX = @cxx@
2323
CGO_CFLAGS = $(ALL_CPPFLAGS)
2424
GOMAXPROCS = @nproc@
2525

26-
.PHONY: all gostatic
27-
all: $(SHLIB)
26+
.PHONY: all purify gostatic
27+
all: purify
2828
$(SHLIB): gostatic
2929

30+
purify: $(SHLIB)
31+
rm -Rf "$(CURDIR)/go/libadbc_driver_flightsql.a"
32+
3033
gostatic:
3134
(cd "$(CURDIR)/go/adbc"; GOMAXPROCS=$(GOMAXPROCS) GOPATH="$(CURDIR)/.go-path" GOCACHE="$(CURDIR)/.go-cache" GOFLAGS=-modcacherw CC="$(CGO_CC)" CXX="$(CGO_CXX)" CGO_CFLAGS="$(CGO_CFLAGS)" CGO_LDFLAGS="$(PKG_LIBS)" "@gobin@" build -v -tags driverlib -o $(CURDIR)/go/libadbc_driver_flightsql.a -buildmode=c-archive "./pkg/flightsql")

0 commit comments

Comments
 (0)