-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to build on Windows with MSYS2 #2326
Comments
In general we don't have much Windows expertise here, so contributions are welcome. (I suppose MSYS2 doesn't need dllimport/dllexport?) |
Ah, we may not need diff --git a/c/include/arrow-adbc/adbc.h b/c/include/arrow-adbc/adbc.h
index b965672e6..94be40a34 100644
--- a/c/include/arrow-adbc/adbc.h
+++ b/c/include/arrow-adbc/adbc.h
@@ -158,8 +158,18 @@ struct ArrowArrayStream {
#else
#define ADBC_EXPORT __declspec(dllimport)
#endif // defined(ADBC_EXPORTING)
+#if defined(__cplusplus)
+#if defined(ADBC_EXPORTING)
+#define ADBC_EXPORT_STRUCT __declspec(dllexport)
+#else
+#define ADBC_EXPORT_STRUCT __declspec(dllimport)
+#endif // defined(ADBC_EXPORTING)
+#else
+#define ADBC_EXPORT_STRUCT
+#endif // defined(__cplusplus)
#else
#define ADBC_EXPORT
+#define ADBC_EXPORT_STRUCT
#endif // defined(_WIN32)
#endif // !defined(ADBC_EXPORT)
|
|
Hmm. Microsoft isn't offering the developer VM anymore... |
I've tried the solution: remove ADBC_EXPORT for struct, then pass the compilation:
The build pipe will throw exception while building with command:
The console output is
|
@taozuhong what version of Go are you using? And how was it installed? You seem to be missing standard library packages |
Or your GOROOT or GOPATH may not be configured properly |
the console output has updated in the previous response. |
Hmm shouldn't your GOROOT point to your Go installation? It seems to just point into the root of your MSYS installation which would explain why Go can't find standard library modules |
The go compiler installs at /ucrt64/bin folder, then the GOROOT set as the MSYS installation folder. I'm a newbie to GO language, I don't know how to fix it. |
It seems
Is that true for you? If not, the GOROOT needs to be set so that this is true. |
Right exactly, I dipped into the MINGW go package, found GO compiler installed at path
|
There are three copies of the header files, should fix it: |
that is intentional |
Just remove
|
Please see page: msys2/MINGW-packages#22754 |
I've tried this solution, it will break the build pipe with CLANG compiler, it throws many warn messages
|
What happened?
Stack Trace
How can we reproduce the bug?
The commands to reproduce the bug
Environment/Setup
The text was updated successfully, but these errors were encountered: