Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Set table name from ctx functions #260

Merged

Conversation

simicd
Copy link
Contributor

@simicd simicd commented Mar 6, 2023

Which issue does this PR close?

Closes #259

Rationale for this change

Possibility to set table name when constructing dataframe from Arrow table/Python dictionary/pandas/polars

What changes are included in this PR?

See above

Are there any user-facing changes?

Optional name parameter in create_dataframe and from_ functions

@simicd simicd force-pushed the feature/table-name-in-from-ctx-functions branch from 908d457 to c23c940 Compare March 6, 2023 23:03
Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very handy addition

.simple()
.encode_lower(&mut Uuid::encode_buffer());
let table_name = match name {
Some(val) => val.to_owned(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @simicd and thanks @jdye64 for the review.

@andygrove andygrove merged commit 9fc5332 into apache:main Mar 7, 2023
@simicd simicd deleted the feature/table-name-in-from-ctx-functions branch March 8, 2023 22:42
@andygrove andygrove added the enhancement New feature or request label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting table name in from_... functions
3 participants