-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at getting architectured builds working #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
commented
Apr 27, 2023
charlesbluca
commented
May 3, 2023
andygrove
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in this area, but the changes look reasonable to me. Thanks @charlesbluca!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When attempting to import the generated conda nightlies on a non-Linux OS, we get an error message looking something like:
I'm fairly sure this is due to the package being built as
noarch
right now, and I think can be resolved by specifying an architecture-dependent Rust compiler at build time (though probably won't be able to get full verification on this until we run against conda-forge's CI if we intend to publish there).What changes are included in this PR?
Modifications to the conda nightly recipe to enable architectured builds of the nightly packages, which should hopefully unblock import errors on other operating systems.
Might also push some temporary changes to roughly verify that things build correctly on Windows/macOS, though was planning to follow dask-sql's practice of only testing builds against Linux.