Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at getting architectured builds working #350

Merged
merged 15 commits into from
Oct 23, 2023

Conversation

charlesbluca
Copy link
Contributor

Rationale for this change

When attempting to import the generated conda nightlies on a non-Linux OS, we get an error message looking something like:

>>> import datafusion
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/charlesb/mambaforge/envs/test-datafustion-packages/lib/python3.10/site-packages/datafusion/__init__.py", line 28, in <module>
    from ._internal import (
ImportError: dlopen(/Users/charlesb/mambaforge/envs/test-datafustion-packages/lib/python3.10/site-packages/datafusion/_internal.abi3.so, 0x0002): tried: '/Users/charlesb/mambaforge/envs/test-datafustion-packages/lib/python3.10/site-packages/datafusion/_internal.abi3.so' (not a mach-o file), '/System/Volumes/Preboot/Cryptexes/OS/Users/charlesb/mambaforge/envs/test-datafustion-packages/lib/python3.10/site-packages/datafusion/_internal.abi3.so' (no such file), '/Users/charlesb/mambaforge/envs/test-datafustion-packages/lib/python3.10/site-packages/datafusion/_internal.abi3.so' (not a mach-o file)

I'm fairly sure this is due to the package being built as noarch right now, and I think can be resolved by specifying an architecture-dependent Rust compiler at build time (though probably won't be able to get full verification on this until we run against conda-forge's CI if we intend to publish there).

What changes are included in this PR?

Modifications to the conda nightly recipe to enable architectured builds of the nightly packages, which should hopefully unblock import errors on other operating systems.

Might also push some temporary changes to roughly verify that things build correctly on Windows/macOS, though was planning to follow dask-sql's practice of only testing builds against Linux.

@charlesbluca charlesbluca marked this pull request as ready for review April 27, 2023 20:36
conda/recipes/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in this area, but the changes look reasonable to me. Thanks @charlesbluca!

@andygrove andygrove merged commit aaaeeb1 into apache:main Oct 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants