-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add ASF attribution #580
Conversation
1ef2fd1
to
b165eaa
Compare
3ddcf2f
to
696fe2c
Compare
696fe2c
to
ba61372
Compare
Thanks @simicd but could we just do the documentation changes in this PR rather than make functional changes to the code as well? |
Thanks for the feedback @andygrove, sure will do that. Background: The changes were required to make it work (on Windows, not sure if Linux has those issues too):
So I thought I leave these changes in to make the builds reproducible. I will now limit the changes to docs only and raise a separate ticket & PR for the remaining issue(s). |
8e32dc3
to
6a03d6a
Compare
Undid the changes that are not directly related to docs, please let me know if you have any further suggestions! |
copyright = "2022, Apache Software Foundation" | ||
author = "Arrow DataFusion Authors" | ||
project = "Apache Arrow DataFusion" | ||
copyright = "2019-2024, Apache Software Foundation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the starting year remain 2022 or be 2019?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 2019 is good, because that was when the project became part of Apache Arrow
Which issue does this PR close?
Closes #553
Rationale for this change
Aligning Apache Software Foundation attribution across projects
What changes are included in this PR?
Are there any user-facing changes?
Updated footer on documentation website