Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant ScalarValue Boxed Collection #2449

Closed
tustvold opened this issue May 5, 2022 · 1 comment · Fixed by #2523
Closed

Redundant ScalarValue Boxed Collection #2449

tustvold opened this issue May 5, 2022 · 1 comment · Fixed by #2523
Assignees
@tustvold
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tustvold
Copy link
Contributor

tustvold commented May 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ScalarValue::List and ScalarValue::Struct contain a Box<Vec<_>> this adds a redundant level of boxing. Clippy in fact complains about this, but this has been suppressed with #[allow(clippy::box_collection)]

Describe the solution you'd like

Remove the additional Box
@tustvold tustvold added enhancement New feature or request good first issue Good for newcomers labels May 5, 2022
@tustvold tustvold self-assigned this May 5, 2022
This was referenced May 13, 2022
Closed
Merged
@comphead
Copy link
Contributor

@tustvold please check the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@tustvold @comphead