Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_push_down panics on semi/anti join with join filters #2888

Closed
andygrove opened this issue Jul 12, 2022 · 0 comments · Fixed by #3723
Closed

filter_push_down panics on semi/anti join with join filters #2888

andygrove opened this issue Jul 12, 2022 · 0 comments · Fixed by #3723
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Since merging ae6dab0 we support join filters on semi/anti joins, although this won't be exposed to end-users until #2885 is merged.

The following code is not correct:

            // Semi/Anti joins can not have join filter.
            JoinType::Semi | JoinType::Anti => unreachable!(
                "on_lr_is_preserved cannot be appplied to SEMI/ANTI-JOIN nodes"
            ),

Describe the solution you'd like
Not sure what the solution is but we shouldn't panic.

Describe alternatives you've considered
None

Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant