Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Debug for ColumnarValue #2950

Closed
iajoiner opened this issue Jul 21, 2022 · 1 comment · Fixed by #3076
Closed

Implement Debug for ColumnarValue #2950

iajoiner opened this issue Jul 21, 2022 · 1 comment · Fixed by #3076
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Jul 21, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I'm frustrated because ColumnarValue does not have Debug implemented which makes debugging harder.

Describe the solution you'd like
I'd like to implement Debug for ColumnarValue. Since it is already implemented for both Array and ScalarValue it should be very straightforward.

Describe alternatives you've considered
Something like columnar_value.map(|cv| cv.into_array(1)) is doable but it is still not very straightforward.

@iajoiner iajoiner added the enhancement New feature or request label Jul 21, 2022
@alamb alamb added the good first issue Good for newcomers label Aug 3, 2022
@alamb alamb self-assigned this Aug 8, 2022
@alamb
Copy link
Contributor

alamb commented Aug 8, 2022

Proposed fix: #3076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants