Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify implementation of approx_median so that it can be exposed in Python #3063

Closed
andygrove opened this issue Aug 7, 2022 · 0 comments · Fixed by #3064
Closed

Simplify implementation of approx_median so that it can be exposed in Python #3063

andygrove opened this issue Aug 7, 2022 · 0 comments · Fixed by #3064
Assignees
@andygrove
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
ApproxMedian is not fully implemented and calls unimplemented!() at runtime, so we can't call it from Python. It works in DataFusion because the SQL query planner translates the approx_median call to approx_percentile. It seems it is not possible to call approx_median from the DataFrame API currently.

Describe the solution you'd like
Have ApproxMedian delegate to ApproxPercentile instead of translating during planning.

Describe alternatives you've considered
None

Additional context
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify approx_median implementation, expose via DataFrame API andygrove/datafusion
1 participant
@andygrove