Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RowAccumulator public #3138

Closed
iajoiner opened this issue Aug 14, 2022 · 0 comments · Fixed by #3151
Closed

Make RowAccumulator public #3138

iajoiner opened this issue Aug 14, 2022 · 0 comments · Fixed by #3151
Labels
enhancement New feature or request

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Aug 14, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I'd like to implement AggregateExpr wrappers with side effects and it would be great if RowAccumulator is available outside the crate so that my wrapped AggregateExprs can mirror the raw ones in Datafusion-related behavior.

Describe the solution you'd like
Make RowAccumulator public.

Describe alternatives you've considered
Currently I have to turn RowAccumulator off.

Additional context
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose RowAccumulator in physical_plan iajoiner/arrow-datafusion
1 participant
@iajoiner