Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigOptions creation is slow #3295

Closed
crepererum opened this issue Aug 30, 2022 · 0 comments · Fixed by #3296
Closed

ConfigOptions creation is slow #3295

crepererum opened this issue Aug 30, 2022 · 0 comments · Fixed by #3296
Labels
bug Something isn't working

Comments

@crepererum
Copy link
Contributor

Describe the bug
ConfigOptions::new and ConfigOptions::from_env grow their internal HashMap during creation even though they know that size beforehand.

To Reproduce
Create ConfigOption very often, attach a sampling profiler.

Expected behavior
Be efficient, use HashMap::with_capacity.

Additional context
Nothing.
@crepererum crepererum added the bug Something isn't working label Aug 30, 2022
crepererum added a commit to crepererum/arrow-datafusion that referenced this issue Aug 30, 2022
@crepererum
fix: speed up ConfigOptions creation
8c4ec27 
Fixes apache#3295.
@crepererum crepererum mentioned this issue Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: speed up ConfigOptions creation crepererum/arrow-datafusion
1 participant
@crepererum