Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make from_proto_binary_op public #3489

Closed
askoa opened this issue Sep 14, 2022 · 0 comments · Fixed by #3490
Closed

Make from_proto_binary_op public #3489

askoa opened this issue Sep 14, 2022 · 0 comments · Fixed by #3490
Labels
enhancement New feature or request

Comments

@askoa
Copy link
Contributor

askoa commented Sep 14, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The function from_proto_binary_op converts string to Operator. This function is required by downstream arrow-ballista and currently duplicated in that project. So whenever a new operator is included, the function from_proto_binary_op should be updated in both arrow-datafusion and arrow-ballista project. This is redundant.

https://github.com/apache/arrow-datafusion/blob/5f029cc73755b6800217e370ebe0a7b5e8a6a224/datafusion/proto/src/from_proto.rs#L1518-L1521

Describe the solution you'd like
The solution is to make the function from_proto_binary_op public in arrow-datafusion project and use it in arrow-ballista project.

Additional context
See comments in the below issue for more details.

apache/datafusion-ballista#201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant