We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug CI clippy checks are failing
https://github.com/apache/arrow-datafusion/actions/runs/3386593123/jobs/5626537564
Compiling datafusion-proto v13.0.0 (/__w/arrow-datafusion/arrow-datafusion/datafusion/proto) error: deref which would be done by auto-deref --> datafusion/proto/build.rs:51:17 | 51 | .expect(&*format!("Cannot read {:?}", &descriptor_path)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&format!("Cannot read {:?}", &descriptor_path)` | = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref error: deref which would be done by auto-deref --> datafusion/proto/build.rs:55:17 | 55 | .expect(&*format!( | _________________^ 56 | | "Cannot register descriptors {:?}", 57 | | &descriptor_set 58 | | )) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref help: try this | 55 ~ .expect(&format!( 56 + "Cannot register descriptors {:?}", 57 + &descriptor_set 58 ~ )) |
To Reproduce run rustup update and then cargo clippy
rustup update
cargo clippy
Expected behavior A clear and concise description of what you expected to happen.
Additional context Rust 1.65 was released https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html
https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-165
The text was updated successfully, but these errors were encountered:
Working on this
Sorry, something went wrong.
to fix #4101
alamb
Successfully merging a pull request may close this issue.
Describe the bug
CI clippy checks are failing
https://github.com/apache/arrow-datafusion/actions/runs/3386593123/jobs/5626537564
To Reproduce
run
rustup update
and thencargo clippy
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Rust 1.65 was released https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html
https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-165
The text was updated successfully, but these errors were encountered: