Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Vec<bool> instead of bool in ExecutionPlan::maintains_input_order #4980

Closed
mustafasrepo opened this issue Jan 19, 2023 · 0 comments · Fixed by #5035
Closed

Return Vec<bool> instead of bool in ExecutionPlan::maintains_input_order #4980

mustafasrepo opened this issue Jan 19, 2023 · 0 comments · Fixed by #5035
Labels
enhancement New feature or request

Comments

@mustafasrepo
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently API of maintains_input_order is as follows fn maintains_input_order(&self) -> bool. It returns a boolean indicating whether the executor keeps ordering. Although this is sufficient for most of the executors. For executors with multiple children, this API is insufficient. Consider UnionExec with two children where ordering of children are Sort(a, b) and Sort(a) respectively. The output will be sorted with Sort(a). However, in current API we return false(Returning true would be wrong). However, if we were to update API to return Vec<bool>. We could return vec![false, true]. This will enable us to further optimize physical plans.

Describe the solution you'd like
N.A

Describe alternatives you've considered
N.A

Additional context
N.A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant