Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllogictest] Don't orchestrate the postgres containers with rust / docker #5009

Closed
Tracked by #4460
alamb opened this issue Jan 20, 2023 · 2 comments · Fixed by #5015
Closed
Tracked by #4460

[sqllogictest] Don't orchestrate the postgres containers with rust / docker #5009

alamb opened this issue Jan 20, 2023 · 2 comments · Fixed by #5015
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 20, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
#4834 adds a way to run sqllogictests using postgres 🦾 (kudos to @melgenek )

However, it currently orchestrates the postgres containers with rust test code which means running these tests requires docker to run the (full) datafusion test suit locally

Describe the solution you'd like

  1. Remove testcontainers dependency
  2. Allow sqllogictest PG_COMPAT mode to run against an existing postgres database (supply the connection information)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added the enhancement New feature or request label Jan 20, 2023
@alamb
Copy link
Contributor Author

alamb commented Jan 21, 2023

I am very interested in this task so I am going to try and hack it a bit this morning -- fyi @xudong963 and @melgenek

@alamb
Copy link
Contributor Author

alamb commented Jan 22, 2023

#5015 is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant