Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy failures in master branch and in PRs (due to new nightly Rust) #5080

Closed
andygrove opened this issue Jan 26, 2023 · 0 comments · Fixed by #5081
Closed

Clippy failures in master branch and in PRs (due to new nightly Rust) #5080

andygrove opened this issue Jan 26, 2023 · 0 comments · Fixed by #5081
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

andygrove commented Jan 26, 2023

Describe the bug

This started happening in master and in PRs.

This seems to be because of changes in rust version 1.69.0-nightly (c18a5e8a5 2023-01-25)

error: variables can be used directly in the `format!` string
   --> datafusion/common/src/config.rs:343:48
    |
343 |               _ => Err(DataFusionError::Internal(format!(
    |  ________________________________________________^
344 | |                 "Config value \"{}\" not found on ConfigOptions",
345 | |                 key
346 | |             ))),
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `-D clippy::uninlined-format-args` implied by `-D warnings`

error: variables can be used directly in the `format!` string
   --> datafusion/common/src/error.rs:290:17
    |
290 |                 write!(f, "Avro error: {}", desc)
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

**To Reproduce**
Steps to reproduce the behavior:

**Expected behavior**
A clear and concise description of what you expected to happen.

**Additional context**
Add any other context about the problem here.
@andygrove andygrove added the bug Something isn't working label Jan 26, 2023
@andygrove andygrove changed the title Clippy failures in master branch and in PRs Clippy failures in master branch and in PRs (due to new nightly Rust) Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant