-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation for ballista in stand-alone mode #1008
Conversation
Problem here https://github.com/apache/arrow-datafusion/blob/master/ballista/rust/executor/src/standalone.rs#L55 |
I verified that the When we fix the ballista test, I recommend we start running the standalone client tests as part of CI so they aren't broken again |
This seems like an improvement to me, so merging it in. We can always improve things more in the future |
Thanks again @Igosuki |
So how do we fix the ballista test though ? I don't understand why the tonic server is unreachable since even if the thread gets detached because the tokio JoinHandle gets dropped it should still be running right ? |
Sorry @Igosuki I am not super familiar with the ballista codebase yet. What test are you referring to (aka what command are you running locally that is failing)? With that information I can file a ticket for the problem and probably find someone in the community who can help fix it |
Filed #1020 to track test failing |
Which issue does this PR close?
Closes #1000
Rationale for this change
API changes broke compilation and execution of the standalone ballista client.
What changes are included in this PR?
Compilation fixes, and another fix is required for tests to pass
Are there any user-facing changes?
None