minor code refinement: if_exists name change, wildcard field for logical plan, etc.
#1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
commented
Mar 8, 2022
| @@ -191,7 +191,7 @@ pub struct DropTable { | |||
| /// The table name | |||
| pub name: String, | |||
| /// If the table exists | |||
| pub if_exist: bool, | |||
| pub if_exists: bool, | |||
There was a problem hiding this comment.
Consistent with Statement::Drop
| @@ -194,7 +182,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| { | |||
| Ok(LogicalPlan::DropTable(DropTable { | |||
| name: names.get(0).unwrap().to_string(), | |||
| if_exist: *if_exists, | |||
| if_exists: *if_exists, | |||
There was a problem hiding this comment.
After https://github.com/apache/arrow-datafusion/pull/1945/files merged, here can directly if_exists
github-actions
bot
added
datafusion
houqp
approved these changes
Mar 8, 2022
jimexist
changed the title
if_exists name change, wildcard field for logical plan, etc.
alamb
added a commit
that referenced
this pull request
Mar 10, 2022
* emit some clone * optimize code with clippy * make code clearer * resolve conflicts with #1951 Co-authored-by: xudong.w <wxd963996380@gmail.com> Co-authored-by: xudong.w <wxd963996380@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Code found during the code review process that could be refined.