Make row its crate to make it accessible from physical-expr #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Apr 20, 2022
andygrove
reviewed
Apr 21, 2022
| [package] | ||
| name = "datafusion-row" | ||
| description = "Row backed by raw bytes for DataFusion query engine" | ||
| version = "7.0.0" |
There was a problem hiding this comment.
Do we really want to start with version 7.0.0 for this crate?
There was a problem hiding this comment.
I think this is following the model of the other datafusion sub crates (which are all versioned the same -- 7.0.0).
alamb
approved these changes
Apr 21, 2022
| [package] | ||
| name = "datafusion-row" | ||
| description = "Row backed by raw bytes for DataFusion query engine" | ||
| version = "7.0.0" |
There was a problem hiding this comment.
I think this is following the model of the other datafusion sub crates (which are all versioned the same -- 7.0.0).
andygrove
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2188.
Based on #2261.
Rationale for this change
To use row in physical aggregation expressions.
What changes are included in this PR?
Move row out of datafusion core to its own crate.
Are there any user-facing changes?
Yes, but the row itself is behind a feature gate and still under development.