Minor: Use ExprVisitor to find columns referenced by expr #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 6, 2022
| @@ -251,77 +251,6 @@ pub enum Expr { | |||
| QualifiedWildcard { qualifier: String }, | |||
| } | |||
|
|
|||
| /// Recursively find all columns referenced by an expression | |||
| pub fn find_columns_referenced_by_expr(e: &Expr) -> Vec<Column> { | |||
There was a problem hiding this comment.
it is less code, but it also avoids potential issues in missing a sub expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #2464
Rationale for this change
I noticed some code that duplicates Expr tree walking, and rewrote it to use ExprVisitor
What changes are included in this PR?
Rewrite
find_columns_referenced_by_exprfrom #2464Are there any user-facing changes?
no