Remove ExecutionProps dependency from OptimizerRule
#2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
andygrove
changed the title
ExecutionProps dependency from OptimizerRuleExecutionProps dependency from OptimizerRule
yjshen
approved these changes
Jun 1, 2022
alamb
approved these changes
Jun 1, 2022
Comment on lines
+1379
to
1382
| let mut optimizer_config = OptimizerConfig::new(); | ||
| optimizer_config.query_execution_start_time = | ||
| self.execution_props.query_execution_start_time; | ||
|
|
There was a problem hiding this comment.
This might look nicer with a builder style:
Suggested change
| let mut optimizer_config = OptimizerConfig::new(); | |
| optimizer_config.query_execution_start_time = | |
| self.execution_props.query_execution_start_time; | |
| let optimizer_config = OptimizerConfig::new() | |
| .with_query_execution_start_time( | |
| self.execution_props.query_execution_start_time | |
| ); | |
|
Thanks @alamb. I will make that change in one of the follow on PRs. |
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 31, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2614
Rationale for this change
What changes are included in this PR?
OptimizerRuletrait no longer referencesExecutionPropsOptimizerRuletrait now referencesOptimizerConfiginstead, which contains the one value (query start time) that it was previously getting fromExecutionPropsAre there any user-facing changes?
Yes if they are using this API
Does this PR break compatibility with Ballista?
TBD