Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Rewrite imports in optimizer moduler #2667

Merged
merged 17 commits into from
Jun 1, 2022
Merged

MINOR: Rewrite imports in optimizer moduler #2667

merged 17 commits into from
Jun 1, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 31, 2022 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

Step towards moving optimizer rules to their own crate

What changes are included in this PR?

Rewrite imports to use source crates and not re-exports in core crate

Are there any user-facing changes?

No

Does this PR break compatibility with Ballista?

No

@github-actions github-actions bot added core Core DataFusion crate datafusion Changes in the datafusion crate optimizer Optimizer rules labels May 31, 2022
@andygrove andygrove self-assigned this May 31, 2022
@andygrove andygrove changed the title WIP: Rewrite imports in optimizer moduler MINOR: Rewrite imports in optimizer moduler Jun 1, 2022
@andygrove andygrove marked this pull request as ready for review June 1, 2022 14:10
@andygrove
Copy link
Member Author

andygrove commented Jun 1, 2022 •
edited
Loading

@alamb @tustvold @yjshen This PR is ready for review and just changes imports. The next PR after this (#2675) will create the new datafusion-optimizer crate and start moving rules over.

@andygrove andygrove mentioned this pull request Jun 1, 2022
Merged
alamb
alamb approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 71ba457 into apache:master Jun 1, 2022
@andygrove andygrove deleted the cleanup-optimizer-imports branch June 1, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees

@andygrove andygrove

Labels
core Core DataFusion crate datafusion Changes in the datafusion crate optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andygrove @alamb