-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move physical expression planning to datafusion-physical-expr
crate
#2682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2682 +/- ##
=======================================
Coverage 84.63% 84.64%
=======================================
Files 267 269 +2
Lines 46867 46926 +59
=======================================
+ Hits 39665 39719 +54
- Misses 7202 7207 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I obviously didn't review this entire PR in detail but I checked that the tests remained intact and everything else looks good. Thank you @andygrove I really like how the modularization is proceeding
Which issue does this PR close?
Closes #2535
Rationale for this change
The main motivation was to not have SimplifyExpressions depend on the core datafusion crate so that we can move it to the new
datafusion-optimizer
crateWhat changes are included in this PR?
Move the following items from core to
datafusion-physical-expr
:create_physical_expr
ExecutionProps
VarProvider
ScalarFunctionExpr
Are there any user-facing changes?
Not too much since I added re-exports but this is still an API change.