Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2876

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Update CONTRIBUTING.md #2876

merged 1 commit into from
Jul 11, 2022

Conversation

waitingkuo
Copy link
Contributor

@waitingkuo waitingkuo commented Jul 11, 2022

expression code moved to datafusion-expr #2669

Which issue does this PR close?

No issue, just update doc

Rationale for this change

What changes are included in this PR?

doc

Are there any user-facing changes?

expression code  moved to datafusion-expr apache#2669
@codecov-commenter
Copy link

Codecov Report

Merging #2876 (0bef54f) into master (a1a6976) will not change coverage.
The diff coverage is n/a.

❗ Current head 0bef54f differs from pull request most recent head 8eaecc2. Consider uploading reports for the commit 8eaecc2 to get more accurate results

@@           Coverage Diff           @@
##           master    #2876   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         275      275           
  Lines       49010    49010           
=======================================
  Hits        41781    41781           
  Misses       7229     7229           
Impacted Files Coverage Δ
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 74.16% <0.00%> (-0.20%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a6976...8eaecc2. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @waitingkuo

@alamb alamb merged commit b6370ee into apache:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants