Fix release verification script by not overriding ARROW_TEST_DATA
or PARQUET_TEST_DATA
#2917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #2916
Fixes #2719
Rationale for this change
Some people have been seeing the
verify_release_candidate.sh
script fail when verifying arrow releases. The failures are due to paths into the "testing data" which are not properly normalizedWhat changes are included in this PR?
arrow-testing
andparquet-testing
into the standard location (datafusion/testing
anddatafusion/parquet-testing
, respectively) as the submodules so the normal path finding logic can kick inNote here is an example of the contents that are in the tarball (note the presence of
testing
andparquet-testing
), though they are empty.ls /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-10.0.0.XXXXX.s39Dslgg/apache-arrow-datafusion-10.0.0 CHANGELOG.md README.md dev/ rustfmt.toml CODE_OF_CONDUCT.md benchmarks/ docs/ target/ CONTRIBUTING.md ci/ header test-rustup/ Cargo.lock conbench/ integration-tests/ testing/ Cargo.toml datafusion/ parquet-testing/ LICENSE.txt datafusion-cli/ pre-commit.sh* NOTICE.txt datafusion-examples/ python/
Are there any user-facing changes?
Hopefully the verify script works on subsequent releases
Testing
Note that I don't normally have the test environment set:
Prior to this change, running:
Would fail for me locally (with the same diff reported by @nevi-me in #2916). With this change, the same command passes