Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release verification script by not overriding ARROW_TEST_DATA or PARQUET_TEST_DATA #2917

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 15, 2022

Which issue does this PR close?

Fixes #2916
Fixes #2719

Rationale for this change

Some people have been seeing the verify_release_candidate.sh script fail when verifying arrow releases. The failures are due to paths into the "testing data" which are not properly normalized

What changes are included in this PR?

  1. Change the script to check out arrow-testing and parquet-testing into the standard location (datafusion/testing and datafusion/parquet-testing, respectively) as the submodules so the normal path finding logic can kick in

Note here is an example of the contents that are in the tarball (note the presence of testing and parquet-testing), though they are empty.

ls /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-10.0.0.XXXXX.s39Dslgg/apache-arrow-datafusion-10.0.0
CHANGELOG.md         README.md            dev/                 rustfmt.toml
CODE_OF_CONDUCT.md   benchmarks/          docs/                target/
CONTRIBUTING.md      ci/                  header               test-rustup/
Cargo.lock           conbench/            integration-tests/   testing/
Cargo.toml           datafusion/          parquet-testing/
LICENSE.txt          datafusion-cli/      pre-commit.sh*
NOTICE.txt           datafusion-examples/ python/

Are there any user-facing changes?

Hopefully the verify script works on subsequent releases

Testing

Note that I don't normally have the test environment set:

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep ARROW_TEST_DATA
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep PARQUET_TEST_DATA

Prior to this change, running:

./dev/release/verify-release-candidate.sh 10.0.0 1

Would fail for me locally (with the same diff reported by @nevi-me in #2916). With this change, the same command passes

@alamb alamb marked this pull request as ready for review July 15, 2022 11:03
@alamb
Copy link
Contributor Author

alamb commented Jul 15, 2022

@andygrove I don't normally have ARROW_TEST_DATA set. If you do, would you mind running ./dev/release/verify-release-candidate.sh 10.0.0 1 from this branch to make sure it works for you?

@alamb alamb requested a review from andygrove July 15, 2022 11:05
@andygrove
Copy link
Member

@andygrove I don't normally have ARROW_TEST_DATA set. If you do, would you mind running ./dev/release/verify-release-candidate.sh 10.0.0 1 from this branch to make sure it works for you?

Yes, works fine for me, with these env vars set:

$ env | grep TEST_DATA
ARROW_TEST_DATA=/home/andy/git/apache/arrow-datafusion/testing/data
PARQUET_TEST_DATA=/home/andy/git/apache/arrow-datafusion/parquet-testing/data

@alamb alamb merged commit d0496b0 into apache:master Jul 16, 2022
@ursabot
Copy link

ursabot commented Jul 16, 2022

Benchmark runs are scheduled for baseline = fe1995f and contender = d0496b0. d0496b0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/fix_verify_script branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants