Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support window functions in expressions by re-write projection after building window plan #2932

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

HuSen8891
Copy link
Contributor

Which issue does this PR close?

Closes #2869

Rationale for this change

re-write projection after building window plan to make window function run in expressions.

What changes are included in this PR?

re-write projection in datafusion/sql/src/planner.rs

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Jul 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2932 (f888daa) into master (c528986) will increase coverage by 0.01%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
+ Coverage   85.32%   85.34%   +0.01%     
==========================================
  Files         273      273              
  Lines       49343    49362      +19     
==========================================
+ Hits        42102    42127      +25     
+ Misses       7241     7235       -6     
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 81.26% <71.42%> (-0.05%) ⬇️
datafusion/core/tests/sql/window.rs 95.87% <100.00%> (+0.69%) ⬆️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.14% <0.00%> (+0.17%) ⬆️
datafusion/core/src/physical_plan/windows/mod.rs 94.44% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c528986...f888daa. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AssHero

@alamb alamb merged commit 9414a74 into apache:master Jul 18, 2022
@alamb alamb changed the title re-write projection after building window plan Support window functions in expressions by re-write projection after building window plan Jul 18, 2022
@ursabot
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 90e5fd0 and contender = 9414a74. 9414a74 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HuSen8891 HuSen8891 deleted the fix_bug branch July 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window functions not supported in expressions
4 participants