Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for ColumnarValue, add some docs #3076

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 8, 2022

Which issue does this PR close?

Closes #2950

Rationale for this change

It allows for faster / more eronomic development (most recently, #3034 (comment))

What changes are included in this PR?

  1. impl Debug for ColumnarValue
  2. Clean up docstrings (noticed while I was in there)

Are there any user-facing changes?

No

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Aug 8, 2022
Co-authored-by: Andy Grove <andygrove73@gmail.com>
@andygrove andygrove merged commit 31381bf into apache:master Aug 9, 2022
@ursabot
Copy link

ursabot commented Aug 9, 2022

Benchmark runs are scheduled for baseline = 85d5363 and contender = 31381bf. 31381bf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/cv_debug branch August 9, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Debug for ColumnarValue
4 participants