Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: User Guide: Move Data Types and Information Schema to their own pages #3131

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

Move important content into more prominent location

What changes are included in this PR?

  • Move Data Types from sql_status to new page
  • Move Information Schema from sql_status to new page
  • Delete some now redundant content from sql_status

Are there any user-facing changes?

No

@@ -143,104 +143,3 @@ DataFusion is designed to be extensible at all points. To that end, you can prov
## Rust Version Compatibility

This crate is tested with the latest stable version of Rust. We do not currently test against other, older versions of the Rust compiler.

# Supported SQL
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this since this is covered already in "SELECT syntax" page

- `GROUP BY` together with one of the following aggregations: `MIN`, `MAX`, `COUNT`, `SUM`, `AVG`, `CORR`, `VAR`, `COVAR`, `STDDEV` (sample and population)
- `ORDER BY` together with an expression and optional `ASC` or `DESC` and also optional `NULLS FIRST` or `NULLS LAST`

## Supported Functions
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this since most of the functions are now documented in the SQL reference

@andygrove andygrove added the documentation Improvements or additions to documentation label Aug 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2022

Codecov Report

Merging #3131 (6fccf69) into master (b1765f7) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   85.95%   85.88%   -0.08%     
==========================================
  Files         291      291              
  Lines       52382    52758     +376     
==========================================
+ Hits        45025    45310     +285     
- Misses       7357     7448      +91     
Impacted Files Coverage Δ
...on/physical-expr/src/expressions/binary/kernels.rs 52.17% <0.00%> (-10.99%) ⬇️
...ore/src/physical_plan/file_format/chunked_store.rs 62.26% <0.00%> (-5.09%) ⬇️
...tafusion/physical-expr/src/expressions/datetime.rs 84.22% <0.00%> (-2.58%) ⬇️
datafusion/core/tests/path_partition.rs 84.92% <0.00%> (-0.87%) ⬇️
datafusion/core/tests/sql/mod.rs 96.94% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
...sion/core/src/physical_plan/file_format/parquet.rs 94.56% <0.00%> (-0.79%) ⬇️
...afusion/core/src/datasource/file_format/parquet.rs 85.57% <0.00%> (-0.70%) ⬇️
datafusion/common/src/scalar.rs 84.61% <0.00%> (-0.28%) ⬇️
datafusion/core/tests/sql/timestamp.rs 99.81% <0.00%> (-0.19%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove mentioned this pull request Aug 15, 2022
17 tasks
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good -- I added some suggestions as our type support has improved

docs/source/user-guide/sql/data_types.md Outdated Show resolved Hide resolved
docs/source/user-guide/sql/data_types.md Outdated Show resolved Hide resolved
docs/source/user-guide/sql/data_types.md Outdated Show resolved Hide resolved
docs/source/user-guide/sql/data_types.md Outdated Show resolved Hide resolved
andygrove and others added 2 commits August 15, 2022 13:25
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 15, 2022
andygrove and others added 3 commits August 15, 2022 13:25
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@andygrove andygrove merged commit d9dab92 into apache:master Aug 15, 2022
@andygrove andygrove deleted the user-guide-types-info-schema branch August 15, 2022 20:51
@ursabot
Copy link

ursabot commented Aug 15, 2022

Benchmark runs are scheduled for baseline = 4876cd6 and contender = d9dab92. d9dab92 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants